Commits
Benjamin Kietzman authored and Wes McKinney committed d15cb454402
ARROW-4031: [C++] Refactor bitmap building Haven't yet used `TypedBufferBuilder<bool>` for `BooleanBuilder`'s bitmap. Coming soon Author: Benjamin Kietzman <bengilgit@gmail.com> Author: Wes McKinney <wesm+git@apache.org> Closes #3336 from bkietz/ARROW-4031-refactor-bitmap-building and squashes the following commits: 7e28c2e75 <Wes McKinney> Merge remote-tracking branch 'apache/master' into ARROW-4031-refactor-bitmap-building 9479ec148 <Wes McKinney> Fix another doxygen warning e16a8e2e0 <Wes McKinney> Fix doxygen warning 567a53158 <Wes McKinney> Revert "Remove memset statements from BufferBuilder" d48c97381 <Wes McKinney> Add cstring include in bit-util.h 535f68af2 <Wes McKinney> Do not call ZeroPadding if buffer is null 79222c172 <Wes McKinney> Remove memset statements from BufferBuilder 2d3b33abd <Wes McKinney> Revert arrow/buffer.h 0c239c8bc <Wes McKinney> Inline ArrayBuilder::Reserve for better performance 79dfc347f <Wes McKinney> tweak 2a0e26fb4 <Benjamin Kietzman> fixing format issues 89ebde63c <Benjamin Kietzman> correct SetBitsTo; failed to set last byte for longer spans 0b0a4fe34 <Benjamin Kietzman> port TestSetBitsTo from begin,end to offset,length 8ee985d4d <Benjamin Kietzman> use NULLPTR macro instead of nullptr 39a6d977d <Benjamin Kietzman> adding explicit cast to uint8_t c293a3183 <Benjamin Kietzman> fix clang-format issue 0255ab947 <Benjamin Kietzman> don't use a growth factor if we don't need to resize 7fea6cfa2 <Benjamin Kietzman> add using UnsafeAppendToBitmap 46551ea31 <Benjamin Kietzman> remove erroneous size_ reference 360a6b2bf <Benjamin Kietzman> fix erroneous void return type c0cbfd5cf <Benjamin Kietzman> Address some PR review comments 65f25205c <Benjamin Kietzman> Merge branch 'master' into ARROW-4031-refactor-bitmap-building ba35e2bc7 <Benjamin Kietzman> Fixing benchmarks for windows compilation 12478cc41 <Benjamin Kietzman> Merge branch 'master' into ARROW-4031-refactor-bitmap-building 028e761ed <Benjamin Kietzman> ArrayBuilder now uses TypedBufferBuilder<bool> for null bitmaps fb3e75950 <Benjamin Kietzman> adding specialization TypedBufferBuilder<bool> for building bitmaps 2553f4172 <Benjamin Kietzman> rewriting arithmetic TypedBufferBuilder to composition from inheritance