Commits
François Saint-Jacques authored and Wes McKinney committed ce9c6e39142
ARROW-4084: [C++] Make Status static method support variadic arguments
- Static constructors like `Status::Invalid` now supports variadic
arguments à la `Status::Invalid("my", variable, "error message: ", i)`.
- A new macro was added `ARROW_RETURN_IF(cond, status)` which replaces
the previous `ARROW_RETURN_IF_FALSE` but also adds branch prediction
hints. Note that only gandiva was refactored with this macro as
otherwise the code review would have exploded.
- Fixed a bug in memory map implementations not checking the return
code of `mmap` and `mremap`.
Author: François Saint-Jacques <fsaintjacques@gmail.com>
Closes #3228 from fsaintjacques/ARROW-4084-variadic-status-message and squashes the following commits:
a877ab994 <François Saint-Jacques> Travis
890df68f9 <François Saint-Jacques> Remove gandiva expect string message testing
71ecbae7d <François Saint-Jacques> Use perfect forwarding.
774bf9387 <François Saint-Jacques> Add missing string header
bf5cdfe06 <François Saint-Jacques> Removed code printing in status
1d1db49c4 <François Saint-Jacques> Reformat
d9fcad919 <François Saint-Jacques> ARROW-4084: Make Status static method support variadic arguments