Public
  1. Public

arrow

Public

Commits

Pindikura RavindraWes McKinney
906eda2ac5b
Pindikura Ravindra authored and Wes McKinney committed be876eb710b
ARROW-5964: [C++][Gandiva] Remove overflow check after rounding in BasicDecimal128::FromDouble

- std::round can round down also.
- also, there is a check further down for overflow (2^127-1).

Author: Pindikura Ravindra <ravindra@dremio.com>

Closes #4894 from pravindra/arrow-5964 and squashes the following commits:

8d6f37af8 <Pindikura Ravindra> fix tests
eaee1ab9f <Pindikura Ravindra> ARROW-5964: remove overflow check after rounding