Commits
Benjamin Kietzman authored and Wes McKinney committed bbca7178adf
ARROW-4341: [C++] Refactor Primitive builders and BooleanBuilder to use TypedBufferBuilder<T> This reduces code duplication. Author: Benjamin Kietzman <bengilgit@gmail.com> Author: Wes McKinney <wesm+git@apache.org> Closes #3575 from bkietz/ARROW-4341-primitive-builders-use-bufferbuilder and squashes the following commits: 3ef29721b <Wes McKinney> Fix BooleanBuilder::AppendNulls, remove valid_bytes argument from AppendNulls methods 40c4d8d5c <Benjamin Kietzman> TypedBufferBuilder<bool>'s output was not correctly sized b389c1308 <Wes McKinney> Revert changes to arrow/util/logging.h daf524423 <Wes McKinney> Revert change to UnsafeAppend that broke Python unit test 3cc5a0c46 <Wes McKinney> Restore memory zeroing. Add missing override 21ce28558 <Wes McKinney> Fix RETURN_NOT_OK usages d4ab3b539 <Wes McKinney> Move NumericBuilder implementation to headers to avoid symbol visibility concerns 6c1e99d4e <Wes McKinney> Add TypedBufferBuilder<bool> UnsafeAppend compile-time option to not track falses. Restore faster code from before this patch for appending C arrays and vector<bool> 09d2bfe8f <Benjamin Kietzman> reduce unnecessary zeroing in BufferBuilder bd736c3db <Benjamin Kietzman> add ArrowLogIgnore and use for release mode DCHECK* 7ba692cc9 <Benjamin Kietzman> moving to iterator append in NumericBuilder 188b7b9cc <Benjamin Kietzman> fix format 893457306 <Benjamin Kietzman> add explicit cast 88e57fe58 <Benjamin Kietzman> remove PrimitiveBuilder 9c050b4dc <Benjamin Kietzman> Use TypedBufferBuilder for PrimitiveBuilder 078497a38 <Benjamin Kietzman> fix BooleanBuilder::AppendNull 88eb71c97 <Benjamin Kietzman> Use TypedBufferBuilder<bool> in BooleanBuilder