Commits


Dragos Moldovan-Grünfeld authored and Jonathan Keane committed b1b8728ee69
ARROW-14609 [R] left_join by argument error message mismatch This PR makes {arrow} join error messages triggered by wrong column specification in `by` closer to the {dplyr} ones ```r # {dplyr} error message > left_join(iris, iris, by = "made_up_colname") Error: Join columns must be present in data. x Problem with `made_up_colname`. Run `rlang::last_error()` to see where the error occurred. # current {arrow} error message > left_join(arrow_table(iris), arrow_table(iris), by = "made_up_colname") Error in handle_join_by(by, x, y) : all(names(by) %in% names(x)) is not TRUE # error message after this PR > left_join(arrow_table(iris), arrow_table(iris), by = "made_up_colname") Error: Join column must be present in data. x `made_up_colname` not present in x. x `made_up_colname` not present in y. Run `rlang::last_error()` to see where the error occurred. ``` ~This PR also introduces another dependency for {arrow}, namely {glue}. I don't think this to be an issue for the following reasons:~ * ~{glue} is already a second order dependency (via {vctrs} and {tidyselect})~ * ~{glue} is dependency-free, so making it a first order dependency adds a lot of useful functionality without making the {arrow} dependency tree more complex~ **Update**: this PR no longer introduces a dependency on {glue} - it has been split out into a discussion in [Jira](https://issues.apache.org/jira/browse/ARROW-15359). Closes #12179 from dragosmg/join_error_message Authored-by: Dragos Moldovan-Grünfeld <dragos.mold@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>