Commits
Dimitri Vorona authored and Wes McKinney committed aedba2cd81c
ARROW-2822: [C++] Zero padding bytes in PoolBuffer See the [JIRA discussion](https://issues.apache.org/jira/projects/ARROW/issues/ARROW-2822). Author: Dimitri Vorona <vorona@in.tum.de> Closes #2239 from alendit/zero-padding and squashes the following commits: 95bae663 <Dimitri Vorona> Cleanup 27347bc5 <Dimitri Vorona> More precise nullptr use detection 3fd5cbb5 <Dimitri Vorona> Handle nullptr for iterators e2000729 <Dimitri Vorona> More consisten handling of null values 4e829cb5 <Dimitri Vorona> Fix lint warning about nullptr bca761f5 <Dimitri Vorona> Convert to the correct type ee591f4b <Dimitri Vorona> Formatting 0a2c6cbe <Dimitri Vorona> Handle custom template cases 44f02aa7 <Dimitri Vorona> Try function scope suppression 3d3d55ec <Dimitri Vorona> Maybe like this? 924467c3 <Dimitri Vorona> Better disable warning 92d2b14e <Dimitri Vorona> Suppress msvc compiler warning about narrowing conversion 8b681b0b <Dimitri Vorona> Second try to make msvc happy about iterators 33b98c80 <Dimitri Vorona> Whoops, old includes f616ac5d <Dimitri Vorona> msvc complains about unchecked iterators 2906df20 <Dimitri Vorona> Don't include benchmark_main in the benchmark 25a729cb <Dimitri Vorona> lol msvc f6c66db0 <Dimitri Vorona> Deduce type from 0 argument 6ddf8822 <Dimitri Vorona> Assert lazy iterator is const e912f9f7 <Dimitri Vorona> Avoid code duplication 7dae17b8 <Dimitri Vorona> Fix comment dcd6111d <Dimitri Vorona> Formatting 10ec6d5e <Dimitri Vorona> Fix compiler warnings c25f1340 <Dimitri Vorona> Fix comment 114c0adc <Dimitri Vorona> Change the iterator category 227245aa <Dimitri Vorona> Remove couple of unneeded things 8fe80957 <Dimitri Vorona> Fix lint warnings 6259a9c6 <Dimitri Vorona> Add tests and benchmark to lazy range 42827e8c <Dimitri Vorona> WIP lazy iterator cccac055 <Dimitri Vorona> Add AppendValues method which uses iterators and avoid copies in orc adapter 8c8291d0 <Dimitri Vorona> Consume status in test c9e709ab <Dimitri Vorona> Remove extra semicolon de9fe258 <Dimitri Vorona> Remove outdated comments 8b97572c <Dimitri Vorona> Add data() and null_bitmap() with deprecation warning 1f712e3e <Dimitri Vorona> Adjust orc adapter to not to use builders internals 515d316b <Dimitri Vorona> Switch nones_ from NullBuilder to BooleanBuilder b8485bc5 <Dimitri Vorona> Revert NullBuilder changes bfeaa2cc <Dimitri Vorona> Fix comment bed63f7d <Dimitri Vorona> Remove data() and null_bitmap() methods from builder 633a022a <Dimitri Vorona> Add a builder reset method and fix some tests d9ded42a <Dimitri Vorona> Avoid raw data access on unfinished buffer in dictionary 3c91f514 <Dimitri Vorona> Decrease log level 45b66d8c <Dimitri Vorona> Consume status 1f30d421 <Dimitri Vorona> Formatting cf0d3819 <Dimitri Vorona> Prevent a builder unfinished warning 28c64b0c <Dimitri Vorona> Fix NullBuilder and use it in python to arrow conversion d1f0ddb6 <Dimitri Vorona> Consume overflow dicts status e90248c9 <Dimitri Vorona> More consistency with padding zeroing e035716f <Dimitri Vorona> Move finished state unsetting to UnsafeAppendBitmap 4cea9fc8 <Dimitri Vorona> Don't pass shrink_to_fit d2f0db74 <Dimitri Vorona> Add warning on unfinished buffers and fix some problems bd1b3e47 <Dimitri Vorona> Prefer using AllocateBuffer, zero padding where it's impossible a2f56630 <Dimitri Vorona> Add buffer zeroing on allocation and fix copy