Public
  1. Public

arrow

Public

Commits

Adam KrebsKrisztián Szűcs
740231d7c45
Adam Krebs authored and Krisztián Szűcs committed 89b9d8c42bf
ARROW-6785: [JS] Remove superfluous child assignment

From `type.mjs`:
![Screenshot 2019-09-16 15 15 45](https://user-images.githubusercontent.com/931368/64986774-c77b8b00-d895-11e9-9ed7-7d101b283361.png)

TypeScript's data modifiers [automatically create a `this.children = children` assignment](http://www.typescriptlang.org/play/#code/KYDwDg9gTgLgBAYwDYEMDOa4GUZQK4IwA8AKnKDMAHYAmmA3nANoDWwAngFxxq4CWVAOYBdbgBEUMFCXZhgcAL5wAvHBRV2APnIhKtTBKky5pWcAB0OfIQA0cEtvoAoOK8QQqvazGgAKMHgARkh8CHBQwCg0HkjsiAAWfEg0EVTcAGJ8wMmkrBwQAGb2wppMwgCUcM5uNTx4clC+5QDcLrWuMIlo5giJyakqCUkp1K01Cm2uAcGhcILA8DBmAJI0TVXhC3hQVPZmlrgE8Oh7cgfezYqTcNMhYT5WAoLrjBEw27sABlZHRPQAJPROnxur1hqlzABbFBgXy+AqVZTaT6AgrmKgoSHABScVHmJZyBSfcrmABWEAEvk+dmJCgUmk+lwmNTAUAglEIwBoPCkMFmTCw7EhgQgSHxEEeQhIKBEgzhrPZEG4P0IiMc1xqviI6i0NzZPhJYP61EGVDwSCQY3am3eOz1ioFQpFYoe-ClMuEgwA5CqYF6ra4FOVfL7zAqfATgC0nAogA).

I suggest matching the other code and just removing the modifier instead of removing the assignment.

Closes #5394 from akre54/patch-1 and squashes the following commits:

ea97ebafe <Adam Krebs> Update js/src/type.ts
32a126ee4 <Adam Krebs>  Remove superfluous child assignment

Authored-by: Adam Krebs <akre54@users.noreply.github.com>
Signed-off-by: Wes McKinney <wesm+git@apache.org>