Public
  1. Public

arrow

Public

Commits

Kousuke SarutaWes McKinney
ac047b2fd28
Kousuke Saruta authored and Wes McKinney committed 77d3a46e14c
ARROW-4049: [C++] Arrow never use glog even though glog is linked.

The following is a part of arrow/util/logging.cc.

```
#ifdef ARROW_USE_GLOG
typedef google::LogMessage LoggingProvider;
#else
typedef CerrLog LoggingProvider;
#endif
```

As you see, when ARROW_USE_GLOG is defined, glog is intended to be used but it's not never defined and glog is never used.

I've fixed this by adding `add_definition` command when  CMake variable `ARROW_USE_GLOG` is ON.

Author: Kousuke Saruta <sarutak@oss.nttdata.com>

Closes #3196 from sarutak/arrow-use-glog and squashes the following commits:

87be74161 <Kousuke Saruta> Fix to use glog