arrow

ARROW-1467: [JAVA] Fix reset() and allocateNew() in Nullable Value Vectors t…

cc @jacques-n , @icexelloss , @BryanCutler

Things fixed:

1)

allocateNew() in NullableValueVectors allocates extra memory for the validity vector of fixed-width vectors. Instead of doing bits.allocateNew(valueCount + 1), we should simply do bits.allocateNew(valueCount).

AFAIK, the only case where we need an additional valueCount is for the offsetVector and we already do that. Additional valueCount for the validity vector is not needed.

(2)

reset() method should call reset() on the underlying value vector to re-initialize the state (allocation monitor, reader index etc) and zero out the buffers. Right now we just reset the validity vector.

Author: siddharth <siddharth@dremio.com>

Closes #1052 from siddharthteotia/ARROW-1467 and squashes the following commits:

ac903884 [siddharth] addressed review comments
09f899af [siddharth] ARROW-1467: Fix reset() and allocateNew() in Nullable Value Vectors template