Commits
tianchen authored and Micah Kornfield committed 5daba72aef8
ARROW-6083: [Java] Refactor Jdbc adapter consume logic
Related to [ARROW-6083](https://issues.apache.org/jira/browse/ARROW-6083).
Jdbc adapter read from ResultSet looks like:
while (rs.next()) {
for (int i = 1; i <= columnCount; i++)
{ jdbcToFieldVector( rs, i, rs.getMetaData().getColumnType(i), rowCount, root.getVector(rsmd.getColumnName(i)), config); }
rowCount++;
}
And in jdbcToFieldVector has lots of switch-case, that is to see, for every single value from ResultSet we have to do lots of analyzing conditions.
I think we could optimize this using consumer/delegate like avro adapter.
Closes #4978 from tianchen92/ARROW-6083 and squashes the following commits:
6acff423d <tianchen> fix potential leak
85e0ebd82 <tianchen> resolve comments
1318574e7 <tianchen> remove addNull API
fa13e5971 <tianchen> add constructor with no Calendar
2b0aa78d6 <tianchen> resolve comments
aa5c9d927 <tianchen> ARROW-6083: Refactor Jdbc adapter consume logic
Authored-by: tianchen <niki.lj@alibaba-inc.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>