Commits


Cuong Nguyen authored and Sutou Kouhei committed 513d77bf5a2
ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows On Linux, the configuration step of Boost allows selecting a subset of the libraries being built using the `--with-libraries=` flag. However, this flag does not exist in the configure script on Windows, so the bundle building step is actually building all Boost libraries, including those being trimmed: ``` Component configuration: - atomic : building - chrono : building - container : building - date_time : building - exception : building - filesystem : building - headers : building - iostreams : building - locale : building - log : building - mpi : building - program_options : building - python : building - random : building - regex : building - serialization : building - system : building - test : building - thread : building - timer : building - wave : building ``` To select only the necessary libraries on Windows, we can provide the `--with-<library>` flag to `./b2`. Doing so helped me pass the boost building step but the thrift building step failed. This time, it was due to the header file `typeof/incr_registration_group.hpp` missing in Boost (this file is only required on Windows but not on Linux); thus, added that header file to the `trim-boost.sh` script. I verified that this can now build on both Windows and Linux with the commands: ``` mkdir build cd build cmake .. -DARROW_PARQUET=ON cmake --build . ``` On Linux: ``` Component configuration: - atomic : not building - chrono : not building - container : not building - date_time : not building - exception : not building - filesystem : building - headers : not building - iostreams : not building - locale : not building - log : not building - mpi : not building - program_options : not building - python : not building - random : not building - regex : building - serialization : not building - system : building - test : not building - thread : not building - timer : not building - wave : not building ``` On Windows: ``` Component configuration: - atomic : not building - chrono : not building - container : not building - date_time : not building - exception : not building - filesystem : building - headers : not building - iostreams : not building - locale : not building - log : not building - mpi : not building - program_options : not building - python : not building - random : not building - regex : building - serialization : not building - system : building - test : not building - thread : not building - timer : not building - wave : not building ``` Closes #7430 from ctring/master Lead-authored-by: Cuong Nguyen <ctring23@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>