Public
  1. Public

arrow

Public

Commits

Masayuki TakahashiPindikura Ravindra
e881aef02eb
Masayuki Takahashi authored and Pindikura Ravindra committed 454d598b0db
ARROW-5132: [Java] Errors on building gandiva_jni.dll on Windows with Visual Studio 2017

When building gandiva_jni.dll on Windows with Visual Studio 2017, some errors occur.

1. `noexcept` not recognized
```
D:/development/repository/git/arrow/cpp/src/gandiva/precompiled/../../arrow/vendored/datetime/date.h:229:81: error: expected function body after function declarator
CONSTCD11 month_weekday_last operator/(const weekday_last& wdl, int          m) NOEXCEPT;
```

2. Link error
```
error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits,class std::allocator > > google::protobuf::internal::fixed_address_empty_string"
```

3. gandiva_jni.dll not found

```
gandiva_jni.dll was not found inside JAR.
```

This PR fixes above issues.

Author: Masayuki Takahashi <masayuki038@gmail.com>

Closes #4123 from masayuki038/ARROW-5132 and squashes the following commits:

83d36bfd <Masayuki Takahashi> ARROW-5132:  Errors on building gandiva_jni.dll on Windows with Visual Studio 2017
923403cf <Masayuki Takahashi> ARROW-5132:  Errors on building gandiva_jni.dll on Windows with Visual Studio 2017