arrow

ARROW-2393: [C++] Moving ARROW_CHECK_OK_[PREPEND] macros from status.h into util/logging.h since they use the logging infrastructure and shouldn't be in the public API.

Also removing ARROW_RETURN_NOT_OK macro. It is almost exactly the same as RETURN_NOT_OK, but RETURN_NOT_OK is declared inside an arrow namespace block and uses Status instead of ::arrow::Stat. That doesn't really matter, since the macro gets expanded where it's used and users who include Status.h and want to use RETURN_NOT_OK will get compiler errors unless they have a 'using arrow' statement

Author: Joshua Storck <joshua.storck@twosigma.com>

Closes #1904 from joshuastorck/ARROW_2393 and squashes the following commits:

b0ac554a <Joshua Storck> clang formatting fixes
942fef39 <Joshua Storck> Restore ARROW_RETURN_NOT_OK since it's assumed to be part of the public API and used in other codebases
dbcf585f <Joshua Storck> Removing calls of ARROW_RETURN_NOT_OK in favor of RETURN_NOT_OK
0e5830ea <Joshua Storck> Fixes for ARROW-2393. Moving ARROW_CHECK_OK_ macros from status.h into util/logging.h since they use the logging infrastructure and shouldn't be in the public API. Also removing ARROW_RETURN_NOT_OK macro. It is almost exactly the same as RETURN_NOT_OK, but RETURN_NOT_OK is declared inside an arrow namespace block and uses Status instead of ::arrow::Stat. That doesn't really matter, since the macro gets expanded where it's used and users who include Status.h and want to use RETURN_NOT_OK will get compiler errors unless they have a 'using arrow' statement