Commits


Yuhong Guo authored and Antoine Pitrou committed 135d48146e9
ARROW-4583: [Plasma] Fix some small bugs reported by code scan tool We used a static code scan tool to scan arrow code. There are several possible bugs: 1. The return value of `PyDict_SetItem` is not used. 2. Currently, `EventLoop:: Shutdown` should be called explicitly, which is error-prone and causing leak when the user forgets to call it. 3. There is an unclosed file descriptor in `io.cc` when path name is too long. Besides, we also made the following small changes: 1. When we use Plasma in Yarn and when a node uses too much memory, a SIGTERM signal will be sent to Plasma. Current plasma will exit silently. We also some log to plasma store to help us to debug. 2. `ARROW_LOG` will always evaluate the output expression even when it is not enabled, which is not efficient. 3. The constructor of Java class `ObjectStoreData` is private, which is not convenient when we want to create a mock plasma store. 4. Fix a call to `ObjectStoreData` which misplaces `meta` and `data` according to https://github.com/apache/arrow/blob/master/java/plasma/src/main/java/org/apache/arrow/plasma/ObjectStoreLink.java#L32 . Author: Yuhong Guo <yuhong.gyh@antfin.com> Author: Antoine Pitrou <antoine@python.org> Closes #3656 from guoyuhong/fixPlasma and squashes the following commits: 634e36a44 <Antoine Pitrou> Use default argument value to `ConvertPyError` b547f2f5d <Yuhong Guo> remove if from ARROW_LOG 440f0975f <Yuhong Guo> Address comment d3eb22ff8 <Yuhong Guo> Lint 79b4af3ae <Yuhong Guo> Fix and Lint 434a039d2 <Yuhong Guo> Make constructor of ObjectStoreData public b2ddba6ce <Yuhong Guo> Fix misplace of meta and data in PlasmaClient.java a66740258 <Yuhong Guo> Do not evaluate logging strings when logging is not enabled. 5be7b89ff <Yuhong Guo> Fix unclosed fd reported by code scan tool 3a917d41d <Yuhong Guo> Fix not used return value in deserialize.cc reported by code scan tool ed56a4808 <Yuhong Guo> Fix possible unclosed EventLoop reported by code scanning tool 3fed9264a <Yuhong Guo> Add plasma log