arrow

MINOR: [C++][clang-tidy] Disable modernize-use-nodiscard check  (#33837)

Not all functions that return a value should have a `[[nodiscard]]`.

`[[nodiscard]]` adds noise and is better used for functions that:
 1. Return a `Status` or some kind of error code
 2. Have a confusing name like the STL container's `empty()`. The STL uses  `[[nodiscard]]` for `empty()` so people are less likely to call it believing it has the same effect of `clear()`.

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>